Re: Build failures in v4.9-stable-queue (drivers/pinctrl/sh-pfc/pfc-r8a7795.c)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Guenter and Greg,

On 2017-01-18 08:03:48 +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 17, 2017 at 09:22:38PM -0800, Guenter Roeck wrote:
> > drivers/pinctrl/sh-pfc/pfc-r8a7795.c:5191:38: error: array type has incomplete element type ‘struct sh_pfc_bias_info’
> >  static const struct sh_pfc_bias_info bias_info[] = {
> >                                       ^
> > drivers/pinctrl/sh-pfc/pfc-r8a7795.c: In function ‘r8a7795_pinmux_get_bias’:
> > drivers/pinctrl/sh-pfc/pfc-r8a7795.c:5362:9: error: implicit declaration of function ‘sh_pfc_pin_to_bias_info’ [-Werror=implicit-function-declaration]
> >   info = sh_pfc_pin_to_bias_info(bias_info, ARRAY_SIZE(bias_info), pin);
> > 
> > This affects arm64 builds (defconfig, allmodconfig).
> > 
> > Guess something is missing in commit 30c49bf7c504 ("pinctrl: sh-pfc: r8a7795:
> > Use lookup function for bias data"). Copying the author.
> 
> Looks like I need to add c314c9f15aa5 ("pinctrl: sh-pfc: Add helper to
> handle bias lookup table") to handle this.

Yes this commit is also needed.

I see my error that I marked the first commit with a Fixes tag while the 
dependency was not documented. In the future how can I document such 
dependencies?

> 
> Odd that kbuild didn't find this issue, your build system covers more
> than it does :)
> 
> thanks,
> 
> greg k-h

-- 
Regards,
Niklas Söderlund
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]