On 01/11/2017 03:05 PM, David Miller wrote: > From: Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx> > Date: Wed, 11 Jan 2017 12:56:00 +0100 > >> CHPID type "OSN" is a device type which had been used by IBM product >> "Communication Controller for Linux". This product has reached end of >> service in March 2016. Thus OSN support can be removed from the qeth >> driver. >> >> Signed-off-by: Ursula Braun <ubraun@xxxxxxxxxxxxxxxxxx> >> Reviewed-by: Julian Wiedmann <jwi@xxxxxxxxxxxxxxxxxx> >> Reviewed-by: Thomas Richter <tmricht@xxxxxxxxxxxxxxxxxx> > > IBM can certainly decide what physical products it wants to support > or not, but this doesn't directly apply to what the Linux kernel > driver supports. > > We do not unilaterally remove support for a chip from a driver just > because the vendor decides to stop supporting that chip. In fact this > is one of the main benefits and value-adds of Linux. > > I'm not applying a patch series that removes support for a chipset > for this reason, sorry. > Dave, I am not sure, if the stopped chip support of vendors is something equivalent to the removal of OSN-CHPID support for s390. Probably I used misleading terms like "OSN-device" in my patch description: The standard networking card on s390 is called "Open Systems Adapter-Express card" (shortly "OSA-card"), and for sure the qeth driver continues to support it in general. Besides covering traditional Ethernet traffic, an OSA-card can also be used for very IBM-specific purposes. The mode an OSA-card is running is configured outside of Linux in the mainframe hardware configuration. Linux supports a subset of these modes with the qeth and lcs drivers. One very specific OSA-mode is the OSN-mode. This mode is one building block for a Linux-assisted approach that allows existing IBM mainframe operating systems to continue to run IBM Systems Network Architecture (SNA) protocol programs. Just these SNA related code parts in qeth would be removed with this patch. Do you still think it is important to keep code just needed for IBM SNA traffic in the kernel? Token Ring support for instance has been removed in 2012. Isn't this something comparable to my intended removal of OSN-mode support in qeth? In other words: Would it make sense to resend my patch with a better description? Kind regards, Ursula -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html