Re: Hotplug crash fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/01/2017 14:13, Greg Kroah-Hartman wrote:
> On Mon, Jan 09, 2017 at 05:07:06PM +0100, Greg Kroah-Hartman wrote:
>> On Mon, Jan 09, 2017 at 04:53:51PM +0100, Mason wrote:
>>> Hello Thomas,
>>>
>>> Link to the original report:
>>> https://marc.info/?l=linux-arm-kernel&m=148173152524746&w=2
>>>
>>> I do see the two patches in linux-next:
>>>
>>> 9bf11ecce5a2
>>> c1a9eeb938b5
>>
>> These are both in 4.10-rc1, and I see no reason why I couldn't take them
>> in stable right now, but I'll wait for Thomas's ack.
> 
> The first one was already in my list to include, the second one is
> dirt-simple, so I'll queue it up now as well.

Thomas,

If the kernel hadn't crashed in tick_broadcast_setup_oneshot()
then the issue of the dummy timer being too early in the list
wouldn't have been caught, right?

So I'm wondering if it didn't make sense to WARN when bc is NULL
in tick_broadcast_setup_oneshot? (Instead of silently bailing out.)

Regards.

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]