Re: FAILED: patch "[PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359" failed to apply to 4.9-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Larry Finger <Larry.Finger@xxxxxxxxxxxx> writes:

> On 01/09/2017 08:40 AM, Kalle Valo wrote:
>> <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
>>
>>> The patch below does not apply to the 4.9-stable tree.
>>> If someone wants it applied there, or to any other stable or longterm
>>> tree, then please email the backport, including the original git commit
>>> id to <stable@xxxxxxxxxxxxxxx>.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>> ------------------ original commit in Linus's tree ------------------
>>>
>>> From 22b68b93ae2506bd56ee3bf232a51bc8ab955b56 Mon Sep 17 00:00:00 2001
>>> From: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
>>> Date: Mon, 19 Dec 2016 20:38:12 -0600
>>> Subject: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359
>>>
>>> With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of
>>> kfree_skb"), the method used to free an skb was changed because the
>>> kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb()
>>> guards against a NULL value for the argument. Routine dev_kfree_skb_irq()
>>> does not, and a test is needed to prevent kernel panics.
>>>
>>> Fixes: e49656147359 ("rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb")
>>> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
>>> Cc: Stable <stable@xxxxxxxxxxxxxxx> # 4.9+
>>> Cc: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>>> Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
>>
>> Larry, are you planning to port this to 4.9?
>
> No. Apparently I got confused again and my use of the Cc to stable was
> incorrect. Commit 49656147359 was not applied until the 4.10 merge.
> The source of the confusion is related to when the various commits
> appear in the git log for mainline. The code, however, has the final
> word. :)

Ah, ok. I'm actually having similar problems and planning to come up
with a some sort of web page which would show what was the first Linux
release to contain the commit. (git-describe doesn't tell that and AFAIK
there is no other git command to show it.) If only I had more free time :)

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]