This is a note to let you know that I've just added the patch titled
ifb: fix rcu_sched self-detected stalls
to the 3.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ifb-fix-rcu_sched-self-detected-stalls.patch
and it can be found in the queue-3.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 7398bbbc81ad70c664ded751b7fd3417bc944414 Mon Sep 17 00:00:00 2001
From: dingtianhong <dingtianhong@xxxxxxxxxx>
Date: Wed, 10 Jul 2013 12:04:02 +0800
Subject: ifb: fix rcu_sched self-detected stalls
From: dingtianhong <dingtianhong@xxxxxxxxxx>
[ Upstream commit 440d57bc5ff55ec1efb3efc9cbe9420b4bbdfefa ]
According to the commit 16b0dc29c1af9df341428f4c49ada4f626258082
(dummy: fix rcu_sched self-detected stalls)
Eric Dumazet fix the problem in dummy, but the ifb will occur the
same problem like the dummy modules.
Trying to "modprobe ifb numifbs=30000" triggers :
INFO: rcu_sched self-detected stall on CPU
After this splat, RTNL is locked and reboot is needed.
We must call cond_resched() to avoid this, even holding RTNL.
Signed-off-by: Ding Tianhong <dingtianhong@xxxxxxxxxx>
Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/net/ifb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -291,8 +291,10 @@ static int __init ifb_init_module(void)
rtnl_lock();
err = __rtnl_link_register(&ifb_link_ops);
- for (i = 0; i < numifbs && !err; i++)
+ for (i = 0; i < numifbs && !err; i++) {
err = ifb_init_one(i);
+ cond_resched();
+ }
if (err)
__rtnl_link_unregister(&ifb_link_ops);
rtnl_unlock();
Patches currently in stable-queue which might be from dingtianhong@xxxxxxxxxx are
queue-3.4/dummy-fix-oops-when-loading-the-dummy-failed.patch
queue-3.4/ipv6-mcast-always-hold-idev-lock-before-mca_lock.patch
queue-3.4/ifb-fix-oops-when-loading-the-ifb-failed.patch
queue-3.4/ifb-fix-rcu_sched-self-detected-stalls.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html