On Fri, Jan 06, 2017 at 03:18:25PM +0000, Deucher, Alexander wrote: > > -----Original Message----- > > From: gregkh@xxxxxxxxxxxxxxxxxxx [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > > Sent: Friday, January 06, 2017 8:47 AM > > To: Cui, Flora; Zhang, Jerry; Deucher, Alexander > > Cc: stable@xxxxxxxxxxxxxxx > > Subject: WTF: patch "[PATCH] drm/amdgpu: update golden setting for > > verde" was seriously submitted to be applied to the 4.9-stable tree? > > > > The patch below was submitted to be applied to the 4.9-stable tree. > > > > I fail to see how this patch meets the stable kernel rules as found at > > Documentation/stable_kernel_rules.txt. > > > > I could be totally wrong, and if so, please respond to > > <stable@xxxxxxxxxxxxxxx> and let me know why this patch should be > > applied. Otherwise, it is now dropped from my patch queues, never to be > > seen again. > > The golden settings and tiling settings are from the hardware validation teams and fix stability issues with the GPUs. The original golden settings and certain versions of firmware resulted in GPU hangs and incorrect tiling resulting in corrupted displays in come configurations. As for the corrected revision ids, userspace drivers use that information to determine certain factors when setting up commands buffers to send to kernel driver. If that is incorrect it can lead to incorrect state setup and GPU hangs or corrupted displays. These are not super critical as radeon is still the preferred driver for these asic families, but it would be nice to have the fixes in stable. These are patches with no changelog text at all (I don't know how your subsystem maintainer took them in the first place), so how are we supposed to know what hey do? Random tables of data is a bit suspicious for stable kernel patches, as I'm sure you can imagine, especially ones as big as these. Having some information as to exactly what the updates do would be greatly appreciated. I suggest you do that for future patches. If you really think these should be applied to the stable kernel tree(s), can you send them as a patch series so I can apply them, with the information in the changelog as to what they do, these are all now long gone from my patch queue. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html