Re: [PATCH 3.10] ipv6: move DAD and addrconf_verify processing to workqueue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mike,

On Fri, Dec 16, 2016 at 10:16:12AM +0000, Mike Manning wrote:
> From: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>
> 
> commit c15b1ccadb323ea50023e8f1cca2954129a62b51 upstream.
> 
> addrconf_join_solict and addrconf_join_anycast may cause actions which
> need rtnl locked, especially on first address creation.
(...)

Thanks, I'm fine with merging these patches, but a quick check tells me
that at least the first one caused some issues that were later fixed,
for example :

  From 43a43b6040165f7b40b5b489fe61a4cb7f8c4980 Mon Sep 17 00:00:00 2001
  From: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>
  Date: Mon, 31 Mar 2014 20:14:10 +0200
  Subject: [PATCH] ipv6: some ipv6 statistic counters failed to disable bh
  
  After commit c15b1ccadb323ea ("ipv6: move DAD and addrconf_verify
  processing to workqueue") some counters are now updated in process context
  and thus need to disable bh before doing so, otherwise deadlocks can
  happen on 32-bit archs. Fabio Estevam noticed this while while mounting
  a NFS volume on an ARM board.

Can you please have a quick check to ensure that all necessary fixes
that come with these two patches are also identified ? I'll then queue
them all at once.

Thanks!
Willy
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]