On 12/8/16 2:41 AM, Greg KH wrote: > On Wed, Dec 07, 2016 at 10:27:51PM -0800, David Ahern wrote: >> On 12/7/16 10:21 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote: >>> >>> This is a note to let you know that I've just added the patch titled >>> >>> rtnl: fix the loop index update error in rtnl_dump_ifinfo() >>> >>> to the 4.8-stable tree which can be found at: >>> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary >>> >>> The filename of the patch is: >>> rtnl-fix-the-loop-index-update-error-in-rtnl_dump_ifinfo.patch >>> and it can be found in the queue-4.8 subdirectory. >>> >>> If you, or anyone else, feels it should not be added to the stable tree, >>> please let <stable@xxxxxxxxxxxxxxx> know about it. >> >> please drop this patch for 4.8 and all other stable backports. It is a no-op patch. > > If it is a no-op, why is it in Linus's tree now too? Should it be > reverted there? patch does no harm, so it does not need to be reverted. Zhang thought it was a bug when really the goal was performance optimization. To actually do anything requires a change to flip the order of if (link_dump_filtered(dev, master_idx, kind_ops)) goto cont; if (idx < s_idx) goto cont; to if (idx < s_idx) goto cont; if (link_dump_filtered(dev, master_idx, kind_ops)) goto cont; and IMHO that is not a change that needs to be backported. -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html