On 11/23/2016, 12:36 AM, Linus Torvalds wrote:
> Seeing this patch again, I just realized that I think that the "=&"
> asm constraint is unnecessary and probably makes for worse code (and
> comes from an earlier thinko of mine).
>
> I should have just kept it as a plain "=", and the only important part
> of this patch is this one-liner update to __get_user_asm_ex()
>
> On Tue, Nov 22, 2016 at 2:40 PM, Jiri Slaby <jslaby@xxxxxxx> wrote:
>>
>> @@ -384,7 +384,7 @@ do { \
>> asm volatile("1: mov"itype" %1,%"rtype"0\n" \
>> "2:\n" \
>> _ASM_EXTABLE_EX(1b, 2b) \
>> - : ltype(x) : "m" (__m(addr)))
>> + : ltype(x) : "m" (__m(addr)), "0" (0))
>
> where it adds that initialization of zero with the extra
>
> "0" (0)
>
> input.
Ok, I still can change the patch as I have not released the kernel with
that. So I am leaving only this single hunk and dropping the rest.
thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html