Re: [PATCH] rbd: send snapshot context with writes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 23 Jul 2013, Greg KH wrote:
> On Mon, Jul 01, 2013 at 03:40:23PM -0700, Sage Weil wrote:
> > From: Josh Durgin <josh.durgin@xxxxxxxxxxx>
> > 
> > Sending the right snapshot context with each write is required for
> > snapshots to work. Due to the ordering of calls, the snapshot context
> > is never set for any requests. This causes writes to the current
> > version of the image to be reflected in all snapshots, which are
> > supposed to be read-only.
> > 
> > This happens because rbd_osd_req_format_write() sets the snapshot
> > context based on obj_request->img_request. At this point, however,
> > obj_request->img_request has not been set yet, to the snapshot context
> > is set to NULL. Fix this by moving rbd_img_obj_request_add(), which
> > sets obj_request->img_request, before the osd request formatting
> > calls.
> > 
> > This resolves:
> >     http://tracker.ceph.com/issues/5465
> > 
> > Upstream commit is d2d1f17a0dad823a4cb71583433d26cd7f734e08.
> > 
> > CC: stable@xxxxxxxxxxxxxxx   # 3.9
> > Reported-by: Karol Jurak <karol.jurak@xxxxxxxxx>
> > Signed-off-by: Josh Durgin <josh.durgin@xxxxxxxxxxx>
> > Reviewed-by: Sage Weil <sage@xxxxxxxxxxx>
> > ---
> >  drivers/block/rbd.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> 3.9 is now end-of-life, sorry for missing this one before that happened.

No worries. Thanks!

sage
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]