On Thu, Nov 17, 2016 at 11:55:31AM +0100, Daniel Wagner wrote: > Hi Greg, > > On 11/17/2016 08:15 AM, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > From 5690a22d8612e1788b48b4ea53c59868589cd2db Mon Sep 17 00:00:00 2001 > > From: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx> > > Date: Fri, 23 Sep 2016 10:41:57 +0200 > > Subject: xprtrdma: use complete() instead complete_all() > > > > From: Daniel Wagner <daniel.wagner@xxxxxxxxxxxx> > > > > commit 5690a22d8612e1788b48b4ea53c59868589cd2db upstream. > > > > There is only one waiter for the completion, therefore there > > is no need to use complete_all(). Let's make that clear by > > using complete() instead of complete_all(). > > > > The usage pattern of the completion is: > > > > waiter context waker context > > > > frwr_op_unmap_sync() > > reinit_completion() > > ib_post_send() > > wait_for_completion() > > > > frwr_wc_localinv_wake() > > complete() > > I don't think this needs to got into stable. The original code isn't broken. > This patch is a cleanup unless I miss something :) It is needed for the patch after this one in the series. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html