Re: [PATCH v2] i2c: mux: fix up dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 14 November 2016 14:39:54 GMT+00:00, Peter Rosin <peda@xxxxxxxxxx> wrote:
>On 2016-11-14 15:34, Linus Walleij wrote:
>> We get the following build error from UM Linux after adding
>> an entry to drivers/iio/gyro/Kconfig that issues "select I2C_MUX":
>> 
>> ERROR: "devm_ioremap_resource"
>>    [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
>> ERROR: "of_address_to_resource"
>>    [drivers/i2c/muxes/i2c-mux-reg.ko] undefined!
>> 
>> It appears that the I2C mux core code depends on HAS_IOMEM
>> for historical reasons, while CONFIG_I2C_MUX_REG does *not*
>> have a direct dependency on HAS_IOMEM.
>> 
>> This creates a situation where a allyesconfig or allmodconfig
>> for UM Linux will select I2C_MUX, and will implicitly enable
>> I2C_MUX_REG as well, and the compilation will fail for the
>> register driver.
>> 
>> Fix this up by making I2C_MUX_REG depend on HAS_IOMEM and
>> removing the dependency from I2C_MUX.
>> 
>> Cc: stable@xxxxxxxxxxxxxxx
>> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
>> Reported-by: Jonathan Cameron <jic23@xxxxxxxxxxxxxxxxxxxxx>
>> Cc: Jonathan Cameron <jic23@xxxxxxxxxxxxxxxxxxxxx>
>> Cc: Peter Rosin <peda@xxxxxxxxxx>
>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
>Acked-by: Peter Rosin <peda@xxxxxxxxxx>
>
>Thanks!
Thanks for sorting this.
Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx>
>
>Cheers,
>Peter

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]