On Thu, 2016-11-10 at 11:48 -0800, Luis R. Rodriguez wrote: > > I haven't verified that this particular use case actually worked before, > > but this code works with lower timeout values (e.g. 60 in the fallback > > case), so this looks isolated. > > This is true, but as I noted the broken aspect was when the timeout > was set to the max value. > > > The bug was clearly introduced in v4.0 by: > > > > 68ff2a00dbf5 "firmware_loader: handle timeout via > > wait_for_completion_interruptible_timeout()" > > > > So please add a Fixes: and > > > > Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > This I agree with, thanks for that, and because of this then: > > Acked-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx> > > And because of this do recommend it for stable. I would still prefer > at least a new re-submit with the respected tags and a changed commit > log describing the reason for the fix, how the cast is an issue > exactly, and how this is a regression. Hi all, I'm still slightly confused, but I can certainly re-submit it. I've added the CC: stable because I first experienced it on a stable box, but indeed it was during coding a kernel driver so it might not be what's expected in “regression” here. I'll try to collect the tag and rewrite the commit log, then re-submit, hopefully not messing with git send-email this time. Regards, -- Yves-Alexis -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html