Re: [4.4 PATCH] powerpc/eeh: Null check uses of eeh_pe_bus_get

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 27, 2016 at 04:22:15PM +1100, Russell Currey wrote:
> On Thu, 2016-10-27 at 07:12 +0200, Greg KH wrote:
> > On Thu, Oct 27, 2016 at 10:19:45AM +1100, Russell Currey wrote:
> > > eeh_pe_bus_get() can return NULL if a PCI bus isn't found for a given PE.
> > > Some callers don't check this, and can cause a null pointer dereference
> > > under certain circumstances.
> > > 
> > > Fix this by checking NULL everywhere eeh_pe_bus_get() is called.
> > > 
> > > Fixes: 8a6b1bc70dbb ("powerpc/eeh: EEH core to handle special event")
> > > Cc: stable@xxxxxxxxxxxxxxx # v3.11+
> > > Signed-off-by: Russell Currey <ruscur@xxxxxxxxxx>
> > > Reviewed-by: Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx>
> > > Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> > > ---
> > > this specific patch for 4.4 only
> > 
> > Why?  I can't take a "specific patch only" unless you have a whole lot
> > of good description about why, and how, and what, and everything else...
> > 
> > Why can't I just take a patch that is already in Linus's tree?  Whenever
> > we don't do that, it always (yes really), ends up being wrong.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Sorry, that was worded poorly.  This patch is commit
> 04fec21c06e35b169a83e75a84a015ab4606bf5e upstream.
> 
> What I _meant_ is that this patch specifically applies to 4.4.

Ah, that makes a lot more sense, thanks :)

I'll queue this up after this next round of kernels is released in a day
or so.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]