This is a note to let you know that I've just added the patch titled
Do not send SMB3 SET_INFO request if nothing is changing
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
do-not-send-smb3-set_info-request-if-nothing-is-changing.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 18dd8e1a65ddae2351d0f0d6dd4a334f441fc5fa Mon Sep 17 00:00:00 2001
From: Steve French <smfrench@xxxxxxxxx>
Date: Mon, 26 Sep 2016 14:23:08 -0500
Subject: Do not send SMB3 SET_INFO request if nothing is changing
From: Steve French <smfrench@xxxxxxxxx>
commit 18dd8e1a65ddae2351d0f0d6dd4a334f441fc5fa upstream.
[CIFS] We had cases where we sent a SMB2/SMB3 setinfo request with all
timestamp (and DOS attribute) fields marked as 0 (ie do not change)
e.g. on chmod or chown.
Signed-off-by: Steve French <steve.french@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/cifs/smb2inode.c | 6 ++++++
1 file changed, 6 insertions(+)
--- a/fs/cifs/smb2inode.c
+++ b/fs/cifs/smb2inode.c
@@ -266,9 +266,15 @@ smb2_set_file_info(struct inode *inode,
struct tcon_link *tlink;
int rc;
+ if ((buf->CreationTime == 0) && (buf->LastAccessTime == 0) &&
+ (buf->LastWriteTime == 0) && (buf->ChangeTime) &&
+ (buf->Attributes == 0))
+ return 0; /* would be a no op, no sense sending this */
+
tlink = cifs_sb_tlink(cifs_sb);
if (IS_ERR(tlink))
return PTR_ERR(tlink);
+
rc = smb2_open_op_close(xid, tlink_tcon(tlink), cifs_sb, full_path,
FILE_WRITE_ATTRIBUTES, FILE_OPEN, 0, buf,
SMB2_OP_SET_INFO);
Patches currently in stable-queue which might be from smfrench@xxxxxxxxx are
queue-4.4/fix-regression-which-breaks-dfs-mounting.patch
queue-4.4/cleanup-missing-frees-on-some-ioctls.patch
queue-4.4/smb3-guids-should-be-constructed-as-random-but-valid-uuids.patch
queue-4.4/clarify-locking-of-cifs-file-and-tcon-structures-and-make-more-granular.patch
queue-4.4/do-not-send-smb3-set_info-request-if-nothing-is-changing.patch
queue-4.4/set-previous-session-id-correctly-on-smb3-reconnect.patch
queue-4.4/cifs-limit-the-overall-credit-acquired.patch
queue-4.4/fs-cifs-keep-guid-when-assigning-fid-to-fileinfo.patch
queue-4.4/display-number-of-credits-available.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html