On Mon 24-10-16 14:52:23, Johannes Weiner wrote: > On Mon, Oct 24, 2016 at 05:26:03PM +0200, Michal Hocko wrote: [...] > > diff --git a/include/linux/swap.h b/include/linux/swap.h > > index 7ba7dccaf0e7..b28de19aadbf 100644 > > --- a/include/linux/swap.h > > +++ b/include/linux/swap.h > > @@ -266,6 +266,7 @@ static inline void workingset_node_pages_inc(struct radix_tree_node *node) > > > > static inline void workingset_node_pages_dec(struct radix_tree_node *node) > > { > > + VM_BUG_ON(!workingset_node_pages(node)); > > node->count--; > > } > > We should also pull 21f54ddae449 ("Using BUG_ON() as an assert() is > _never_ acceptable") into stable on top of this patch to replace the > BUG_ONs with warnings. > > Otherwise this looks good to me. OK, I have put that one on top and after the review will post it in one series. Thanks for the review Johannes! -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html