Re: [Skiboot] [PATCH] hw/phb3: improve handling of PHB init failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/10/16 16:51, Andrew Donnellan wrote:
PHB initialisation in phb3_init_hw() can fail for a number of reasons, such
as DLP reset timeout, root complex config space init failure, etc. When
this occurs, an error message is printed to the console and the PHB's state
is set to PHB3_STATE_BROKEN.

However, currently both phb3_create() and phb3_creset() will continue on
trying to set up the PHB or reset it respectively. This doesn't seem like a
particularly good idea.

Make phb3_init_hw() return OPAL_HARDWARE on failure, and make phb3_creset()
and phb3_create() abort appropriately on failure.

Cc: stable

Argh, git-send-email interpreted this as a Cc to stable@xxxxxxxxxxxxxxx and I didn't notice...

Please disregard, stable kernel people! skiboot people should probably drop their Cc on replies...

--
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@xxxxxxxxxxx  IBM Australia Limited

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]