On Thu, 20 Oct 2016 08:03:33 +0200, Hui Wang wrote: > > They uses the codec ALC255, and have the different pin cfg definition > from the ones in the existing pin quirk table. Now adding them into > the table to fix the problem. > > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Hui Wang <hui.wang@xxxxxxxxxxxxx> Thanks, applied now. But judging from the increasing number of the table entries, we may rethink how to match the pattern in future. The pincfg table was introduced as a kind of fingerprint to match with the deployed configuration. Maybe the matching should be relaxed (e.g. doesn't care about the assoc#), so that we can reduce the table size. Takashi > --- > sound/pci/hda/patch_realtek.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 8483fc2..b582d57 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5857,11 +5857,19 @@ enum { > {0x1b, 0x02011020}, > {0x21, 0x0221101f}), > SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, > + {0x14, 0x90170110}, > + {0x1b, 0x01011020}, > + {0x21, 0x0221101f}), > + SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, > {0x14, 0x90170130}, > {0x1b, 0x01014020}, > {0x21, 0x0221103f}), > SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, > {0x14, 0x90170130}, > + {0x1b, 0x01011020}, > + {0x21, 0x0221103f}), > + SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, > + {0x14, 0x90170130}, > {0x1b, 0x02011020}, > {0x21, 0x0221103f}), > SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE, > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html