Re: [PATCH] arm64: spinlocks: implement smp_mb__before_spinlock() as smp_mb()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 05, 2016 at 11:56:05AM +0100, Will Deacon wrote:
> smp_mb__before_spinlock() is intended to upgrade a spin_lock() operation
> to a full barrier, such that prior stores are ordered with respect to
> loads and stores occuring inside the critical section.
> 
> Unfortunately, the core code defines the barrier as smp_wmb(), which
> is insufficient to provide the required ordering guarantees when used in
> conjunction with our load-acquire-based spinlock implementation.
> 
> This patch overrides the arm64 definition of smp_mb__before_spinlock()
> to map to a full smp_mb().
> 
> Cc: <stable@xxxxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Reported-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Will Deacon <will.deacon@xxxxxxx>

Queued for -rc6. Thanks.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]