Re: [PATCH] drm/atomic: Don't potentially reset color_mgmt_changed on successive property updates.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 27, 2016 at 01:02:28AM +0200, Mario Kleiner wrote:
> Due to assigning the 'replaced' value instead of or'ing it,
> if drm_atomic_crtc_set_property() gets called multiple times,
> the last call will define the color_mgmt_changed flag, so
> a non-updating call to a property can reset the flag and
> prevent actual hw state updates required by preceding
> property updates.
> 
> Signed-off-by: Mario Kleiner <mario.kleiner.de@xxxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # v4.6+
Fixes: 5488dc16fde7 ("drm: introduce pipe color correction properties")

Oops. I wonder why we didn't catch this in testcases ...

Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>

Dave, can you pls pick this up?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]