On Mon, Aug 15, 2016 at 07:25:53AM -0700, James Bottomley wrote: > On Mon, 2016-08-15 at 22:11 +0800, kbuild test robot wrote: > > Hi Johannes, > > > > [auto build test ERROR on scsi/for-next] > > [also build test ERROR on v4.8-rc2 next-20160815] > > [if your patch is applied to the wrong git tree, please drop us a > > note to help improve the system] > > This is happening because scsi_is_sas_rphy wasn't designed to be used > outside the SAS transport class, so it's failing when the ATTRs aren't > defined. > > This is the way you fix it (needs to be a precursor patch to 1/2): > > James Thanks, but I'm wondering about the call to sas_get_address(). It was there before the patch as well and now it's an undefined reference. Am I missing something here? Sure it can be guarded in the #if block. > > --- > > diff --git a/include/scsi/scsi_transport_sas.h b/include/scsi/scsi_transport_sas.h > index 13c0b2b..0e1c50e 100644 > --- a/include/scsi/scsi_transport_sas.h > +++ b/include/scsi/scsi_transport_sas.h > @@ -15,8 +15,13 @@ static inline int is_sas_attached(struct scsi_device *sdev) > { > return 0; > } > +static inline int scsi_is_sas_rphy(const struct device *) > +{ > + return 0; > +} > #else > extern int is_sas_attached(struct scsi_device *sdev); > +extern int scsi_is_sas_rphy(const struct device *); > #endif > > static inline int sas_protocol_ata(enum sas_protocol proto) > @@ -202,7 +207,6 @@ extern int sas_rphy_add(struct sas_rphy *); > extern void sas_rphy_remove(struct sas_rphy *); > extern void sas_rphy_delete(struct sas_rphy *); > extern void sas_rphy_unlink(struct sas_rphy *); > -extern int scsi_is_sas_rphy(const struct device *); > > struct sas_port *sas_port_alloc(struct device *, int); > struct sas_port *sas_port_alloc_num(struct device *); > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html