On Sun, Aug 14, 2016 at 04:42:09PM +0200, Greg KH wrote:
> On Mon, Jul 18, 2016 at 04:53:15PM -0400, Charles (Chas) Williams wrote:
> > From: Eric Dumazet <edumazet@xxxxxxxxxx>
> >
> > commit 197c949e7798fbf28cfadc69d9ca0c2abbf93191 upstream.
>
> Why isn't this in 4.4-stable? I can't take it into 3.14-stable unless I
> also have it in 4.4, otherwise it would be a regression when people
> upgraded, right?
>
> And if this isn't in 4.4-stable, why not? I'm guessing that the authors
> didn't think it was necessary...
As the commit message says:
This bug does not happen in upstream kernels since Al Viro did a great
job to replace this into :
skb_copy_and_csum_datagram_msg(skb, sizeof(struct udphdr), msg);
This variant is safe vs short buffers.
That happened in 3.19 by commit 227158db1604 ("new helper:
skb_copy_and_csum_datagram_msg()"). The mainline commit is useful as it
prevents calculating the checksum twice but it's not really stable
material; on the other hand, it addresses a serious issue in stable
kernels 3.18 and older (those with backport of commit 89c22d8c3b27).
Michal Kubecek
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html