Re: [PATCH 3.14.y 3/9] cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 18, 2016 at 04:53:17PM -0400, Charles (Chas) Williams wrote:
> From: Bjørn Mork <bjorn@xxxxxxx>
> 
> commit 4d06dd537f95683aba3651098ae288b7cbff8274 upstream.
> 
> usbnet_link_change will call schedule_work and should be
> avoided if bind is failing. Otherwise we will end up with
> scheduled work referring to a netdev which has gone away.
> 
> Instead of making the call conditional, we can just defer
> it to usbnet_probe, using the driver_info flag made for
> this purpose.
> 
> CVE-2016-3951
> 
> Fixes: 8a34b0ae8778 ("usbnet: cdc_ncm: apply usbnet_link_change")
> Reported-by: Andrey Konovalov <andreyknvl@xxxxxxxxx>
> Suggested-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Bjørn Mork <bjorn@xxxxxxx>
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> [ciwillia@xxxxxxxxxxx: backported to 3.14: adjusted context]
> Signed-off-by: Charles (Chas) Williams <ciwillia@xxxxxxxxxxx>
> ---
>  drivers/net/usb/cdc_ncm.c | 20 +++++---------------
>  1 file changed, 5 insertions(+), 15 deletions(-)

Another patch that isn't in 4.4-stable, why not?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]