On 08/02/2016, 09:03 AM, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
> Date: Tue, 19 Apr 2016 12:16:55 -0300
> Subject: perf test: Ignore kcore files in the "vmlinux matches kallsyms" test
>
> From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>
> commit 53d0fe68275dbdaf6a532bb4e87f00db5d36c140 upstream.
...
> --- a/tools/perf/tests/vmlinux-kallsyms.c
> +++ b/tools/perf/tests/vmlinux-kallsyms.c
> @@ -54,8 +54,14 @@ int test__vmlinux_matches_kallsyms(void)
> * Step 3:
> *
> * Load and split /proc/kallsyms into multiple maps, one per module.
> + * Do not use kcore, as this test was designed before kcore support
> + * and has parts that only make sense if using the non-kcore code.
> + * XXX: extend it to stress the kcorre code as well, hint: the list
> + * of modules extracted from /proc/kcore, in its current form, can't
> + * be compacted against the list of modules found in the "vmlinux"
> + * code and with the one got from /proc/modules from the "kallsyms" code.
> */
> - if (machine__load_kallsyms(&kallsyms, "/proc/kallsyms", type, NULL) <= 0) {
> + if (__machine__load_kallsyms(&kallsyms, "/proc/kallsyms", type, true, NULL) <= 0) {
__machine__load_kallsyms is only in 4.7+. So this patch breaks build of
perf:
perf-in.o: In function `test__vmlinux_matches_kallsyms':
tools/perf/tests/vmlinux-kallsyms.c:64: undefined reference to
`__machine__load_kallsyms'
collect2: error: ld returned 1 exit status
Makefile.perf:316: recipe for target 'perf' failed
It is only a test fix, so I think the patch should be dropped from both
4.4 and 4.6.
thanks,
--
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html