On Fri, 2013-07-12 at 17:58 -0700, Darren Hart wrote: > The MinnowBoard uses an AR803x PHY with the PCH GBE which requires > special handling. Use the MinnowBoard PCI Subsystem ID to detect this > and add a pci_device_id.driver_data structure and functions to handle > platform setup. trivial comments only: Please use scripts/checkpatch.pl [] diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c[] [] > +static int pch_gbe_minnow_platform_init(struct pci_dev *pdev) [] > + if (ret){ Missing space before brace > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c [] > +int pch_gbe_phy_tx_clk_delay(struct pch_gbe_hw *hw) [] > + case PHY_AR803X_ID: > + netdev_dbg(adapter->netdev, > + "Configuring AR803X PHY for 2ns TX clock delay\n"); [] > + netdev_err(adapter->netdev, > + "Unknown PHY (%x), could not set TX clock delay.\n", > + hw->phy.id); [] > + netdev_err(adapter->netdev, > + "Could not configure tx clock delay for PHY.\n"); [] > +int pch_gbe_phy_disable_hibernate(struct pch_gbe_hw *hw) [] > + case PHY_AR803X_ID: > + netdev_dbg(adapter->netdev, > + "Disabling hibernation for AR803X PHY\n"); It'd be nice if no period before newline were used everywhere. > + netdev_err(adapter->netdev, > + "Unknown PHY (%x), could not disable hibernation\n", > + hw->phy.id); [] > + netdev_err(adapter->netdev, > + "Could not disable PHY hibernation.\n"); -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html