On Mon, Jul 18, 2016 at 04:27:57PM -0700, Rodrigo Vivi wrote: > This reverts commit 041824ee25cfc535ba2d9a22c217df735ea2471e. > > We have latency issues that might impact the performance: #96606. > and hangs and loading issues on resume after S4: #96526. > > This is also blocking a platform milestone so let's disable > this for now while we make sure we don't have any more loading > issue, or related basic hangs and it pass BAT for real in all > platofmrs. > > In case BAT is wrong let's first fix BAT before re-enable it here. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96606 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96526 > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > Cc: Dave Gordon <david.s.gordon@xxxxxxxxx> > Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx> > Cc: Stable <stable@xxxxxxxxxxxxxxx> > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > Cc: Christophe Prigent <christophe.prigent@xxxxxxxxx> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> Reverts win, even against silly CI. Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > --- > drivers/gpu/drm/i915/i915_params.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 8b13bfa..b6e404c 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -54,8 +54,8 @@ struct i915_params i915 __read_mostly = { > .verbose_state_checks = 1, > .nuclear_pageflip = 0, > .edp_vswing = 0, > - .enable_guc_loading = -1, > - .enable_guc_submission = -1, > + .enable_guc_loading = 0, > + .enable_guc_submission = 0, > .guc_log_level = -1, > .enable_dp_mst = true, > .inject_load_failure = 0, > @@ -203,12 +203,12 @@ MODULE_PARM_DESC(edp_vswing, > module_param_named_unsafe(enable_guc_loading, i915.enable_guc_loading, int, 0400); > MODULE_PARM_DESC(enable_guc_loading, > "Enable GuC firmware loading " > - "(-1=auto [default], 0=never, 1=if available, 2=required)"); > + "(-1=auto, 0=never [default], 1=if available, 2=required)"); > > module_param_named_unsafe(enable_guc_submission, i915.enable_guc_submission, int, 0400); > MODULE_PARM_DESC(enable_guc_submission, > "Enable GuC submission " > - "(-1=auto [default], 0=never, 1=if available, 2=required)"); > + "(-1=auto, 0=never [default], 1=if available, 2=required)"); > > module_param_named(guc_log_level, i915.guc_log_level, int, 0400); > MODULE_PARM_DESC(guc_log_level, > -- > 2.5.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html