>>> On 12.07.13 at 10:32, Wei Liu <wei.liu2@xxxxxxxxxx> wrote: > On Mon, Jul 08, 2013 at 03:20:26PM +0100, Jan Beulich wrote: >> >>> On 08.07.13 at 11:59, "Jan Beulich" <JBeulich@xxxxxxxx> wrote: >> >>>> On 05.07.13 at 16:53, Wei Liu <wei.liu2@xxxxxxxxxx> wrote: >> >> skb->truesize += PAGE_SIZE * skb_shinfo(skb)->nr_frags; >> >> skb->len += skb->data_len; >> >> } >> >> >> >> handle_incoming_packet(); >> >> >> >> You seem to be altering the behavior of the original code, because in >> >> your patch the skb->len is incremented before use, while in the original >> >> code (which calls skb_headlen in handle_incoming_packet) the skb->len is >> >> correctly set. >> > >> > Right. So I basically need to keep skb->len up-to-date along with >> > ->data_len. Just handed a patch to Dion with that done; I'll defer >> > sending a v2 for the upstream code until I know the change works >> > for our kernel. >> >> Okay, so with that done (see below) Dion is now seeing the >> WARN_ON_ONCE(delta < len) in skb_try_coalesce() triggering. Of >> course, with it having crashed before, it's hard to tell whether the >> triggering now is an effect of the patch, or just got unmasked by it. >> > > I just ported your below patch to upstream kernel and I didn't see the > WARN_ON_ONCE. I only did iperf and netperf tests. > > If the work load to trigger this bug is simple enough I can give it a > shot... I'm meanwhile relatively convinced that the warning isn't an effect of the patch (final verification pending); I intend to submit v2 as soon as 3.11-rc1 is out. Jan -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html