Re: [PATCH for-next 2/2] IB/mlx5: Fix iteration overrun in GSI qps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/3/2016 3:28 PM, Leon Romanovsky wrote:
> From: Slava Shwartsman <slavash@xxxxxxxxxxxx>
> 
> Number of outstanding_pi may overflow and as a result may indicate that
> there are no elements in the queue. The effect of doing this is that the
> MAD layer will get stuck waiting for completions. The MAD layer will
> think that the QP is full - because it didn't receive these completions.
> 
> This fix changes it so the outstanding_pi number is increased
> with 32-bit wraparound and is not limited to max_send_wr so
> that the difference between outstanding_pi and outstanding_ci will
> really indicate the number of outstanding completions.
> 
> Cc: Stable <stable@xxxxxxxxxxxxxxx>
> Fixes: ea6dc2036224 ('IB/mlx5: Reorder GSI completions')
> Signed-off-by: Slava Shwartsman <slavash@xxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx>

Reviewed-by: Haggai Eran <haggaie@xxxxxxxxxxxx>

Thanks for this fix,

Haggai

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]