On Mon, Jun 20, 2016 at 7:38 AM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
>
> Overall, we seem to be heading towards the "really weird" territory here.
So the whole commit that Boris bisected down to is weird to me.
Why isn't the temporary text mapping just set up unconditionally in
the temp_level4_pgt?
Why does it have that insane "let's leave the temp_level4_pgt alone
until we actually switch to it, and save away restore_pgd_addr and the
restore_pgd, to then be set up at restore time"?
All the other temporary mappings are set up statically in the
temp_level4_pgt, why not that one?
I suspect whatever corruption happens boils down to the same issue
that made people do that odd decision in the first place.
And regardless, those games are too ugly to live. So I would suggest
that that original commit should just be considered broken, and
reverted (or just removed - I'm not sure if it's in a stable branch or
not) and the fix be rethought so that the code mapping can be done
once and for all and *without* the extra games.
Linus
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html