Re: [PATCH] drm/i915: Use Graphics Base of Stolen Memory on all gen3+

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 04, 2013 at 01:26:03AM +0200, Daniel Vetter wrote:
> On Thu, Jul 4, 2013 at 1:23 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> > So I made the mistake of missing that the desktop and mobile chipsets
> > have different layouts in their PCI configurations, and we were
> > incorrectly setting the wrong physical address for stolen memory on
> > mobile chipsets.
> >
> > Since all gen3+ are actually consistent in the location of the GBSM
> > register in the PCI configuration space on device 2 (the GPU), use it.
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> 
> Nope, not cc: stable since the last time around the overlay blew up in
> flames ...

You can comment out gen3, but the dangerous part is that we are
overwriting random physical addresses.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]