On Thu, Jun 02, 2016 at 04:33:53AM -0700, Christoph Hellwig wrote: > > IB_DEVICE_CROSS_CHANNEL = (1 << 27), > > IB_DEVICE_MANAGED_FLOW_STEERING = (1 << 29), > > IB_DEVICE_SIGNATURE_HANDOVER = (1 << 30), > > - IB_DEVICE_ON_DEMAND_PAGING = (1 << 31), > > + IB_DEVICE_ON_DEMAND_PAGING = (1ULL << 31), > > IB_DEVICE_SG_GAPS_REG = (1ULL << 32), > > IB_DEVICE_VIRTUAL_FUNCTION = ((u64)1 << 33), > > IB_DEVICE_RAW_SCATTER_FCS = ((u64)1 << 34), > > So now we've got three different styles to define the constants. > > I'd really prefer to move all of them over to the 1ULL << offset style. If people can agree on the style that would be a nice followup cleanup patch, but since this fixes a bug and needs a pass through stable shouldn't it stay succinct like this? Jason -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html