Re: [PATCH] IB/core: Fix bit curruption in ib_device_cap_flags structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 6/2/2016 2:33 PM, Christoph Hellwig wrote:
  	IB_DEVICE_CROSS_CHANNEL		= (1 << 27),
  	IB_DEVICE_MANAGED_FLOW_STEERING		= (1 << 29),
  	IB_DEVICE_SIGNATURE_HANDOVER		= (1 << 30),
-	IB_DEVICE_ON_DEMAND_PAGING		= (1 << 31),
+	IB_DEVICE_ON_DEMAND_PAGING		= (1ULL << 31),
  	IB_DEVICE_SG_GAPS_REG			= (1ULL << 32),
  	IB_DEVICE_VIRTUAL_FUNCTION		= ((u64)1 << 33),
  	IB_DEVICE_RAW_SCATTER_FCS		= ((u64)1 << 34),

So now we've got three different styles to define the constants.

My next patch will align casting of IB_DEVICE_VIRTUAL_FUNCTION and IB_DEVICE_RAW_SCATTER_FCS to ULL.


I'd really prefer to move all of them over to the 1ULL << offset style.

me too :)


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]