This is a note to let you know that I've just added the patch titled
USB: serial: quatech2: fix use-after-free in probe error path
to the 4.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-serial-quatech2-fix-use-after-free-in-probe-error-path.patch
and it can be found in the queue-4.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 028c49f5e02a257c94129cd815f7c8485f51d4ef Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@xxxxxxxxxx>
Date: Sun, 8 May 2016 20:08:02 +0200
Subject: USB: serial: quatech2: fix use-after-free in probe error path
From: Johan Hovold <johan@xxxxxxxxxx>
commit 028c49f5e02a257c94129cd815f7c8485f51d4ef upstream.
The interface read URB is submitted in attach, but was only unlinked by
the driver at disconnect.
In case of a late probe error (e.g. due to failed minor allocation),
disconnect is never called and we would end up with active URBs for an
unbound interface. This in turn could lead to deallocated memory being
dereferenced in the completion callback.
Fixes: f7a33e608d9a ("USB: serial: add quatech2 usb to serial driver")
Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/usb/serial/quatech2.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/usb/serial/quatech2.c
+++ b/drivers/usb/serial/quatech2.c
@@ -141,6 +141,7 @@ static void qt2_release(struct usb_seria
serial_priv = usb_get_serial_data(serial);
+ usb_kill_urb(serial_priv->read_urb);
usb_free_urb(serial_priv->read_urb);
kfree(serial_priv->read_buffer);
kfree(serial_priv);
Patches currently in stable-queue which might be from johan@xxxxxxxxxx are
queue-4.6/usb-serial-quatech2-fix-use-after-free-in-probe-error-path.patch
queue-4.6/usb-serial-option-add-support-for-cinterion-ph8-and-ahxx.patch
queue-4.6/usb-serial-io_edgeport-fix-memory-leaks-in-attach-error-path.patch
queue-4.6/usb-serial-mxuport-fix-use-after-free-in-probe-error-path.patch
queue-4.6/usb-serial-option-add-even-more-zte-device-ids.patch
queue-4.6/usb-serial-keyspan-fix-use-after-free-in-probe-error-path.patch
queue-4.6/usb-serial-cp210x-fix-hardware-flow-control-disable.patch
queue-4.6/usb-serial-option-add-more-zte-device-ids.patch
queue-4.6/usb-serial-io_edgeport-fix-memory-leaks-in-probe-error-path.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html