On Tue, May 24, 2016 at 12:12 PM, Mario Kleiner
<mario.kleiner.de@xxxxxxxxx> wrote:
> When porting the hdmi deep color detection code from
> radeon-kms to amdgpu-kms apparently some kind of
> copy and paste error happened, attaching an else
> branch to the wrong if statement.
>
> The result is that hdmi deep color mode is always
> disabled, regardless of gpu and display capabilities and
> user wishes, as the code mistakenly thinks that the display
> doesn't provide the required max_tmds_clock limit and falls
> back to 8 bpc.
>
> This patch fixes deep color support, as tested on a
> R9 380 Tonga Pro + suitable display, and should be
> backported to all kernels with amdgpu-kms support.
>
> Signed-off-by: Mario Kleiner <mario.kleiner.de@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> index 60a0c9a..cb07da4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c
> @@ -194,12 +194,12 @@ int amdgpu_connector_get_monitor_bpc(struct drm_connector *connector)
> bpc = 8;
> DRM_DEBUG("%s: HDMI deep color 10 bpc exceeds max tmds clock. Using %d bpc.\n",
> connector->name, bpc);
> - } else if (bpc > 8) {
> - /* max_tmds_clock missing, but hdmi spec mandates it for deep color. */
> - DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing. Using 8 bpc.\n",
> - connector->name);
> - bpc = 8;
> }
> + } else if (bpc > 8) {
> + /* max_tmds_clock missing, but hdmi spec mandates it for deep color. */
> + DRM_DEBUG("%s: Required max tmds clock for HDMI deep color missing. Using 8 bpc.\n",
> + connector->name);
> + bpc = 8;
> }
> }
>
> --
> 2.7.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html