Re: [PATCH] cdc-wdm: fix "out-of-sync" due to missing notifications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2016-05-13 at 18:59 +0200, Bjørn Mork wrote:
> Bjørn Mork <bjorn@xxxxxxx> writes:
> 
> > The driver enforces a strict one-to-one relationship between the
> > received RESPONSE_AVAILABLE notifications and messages read from
> > the device. At the same time, it will cancel the interrupt URB
> > when there is no client holding the character device open.
> 
> Never mind.  Forget it.
> 
> This patch breaks other devices again.  The immediate and unconditional
> reading make them barf. I guess it can be worked around by delaying the
> flushing until at least one notification is received, but I obviously
> have to test this theory thoroughly on all devices I have.

Hi,

I think the best approach would be to keep the interrupt URB always
active. I didn't do this to conserve bandwidth, but if it makes devices
work, it certainly would be the best option.

	Regards
		Oliver


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]