Re: [PATCH 2/2] target: fix max discard sectors calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>>> "Bart" == Bart Van Assche <bart.vanassche@xxxxxxxxxxx> writes:

Bart> That's a good catch. But seeing this patch makes me wonder whether
Bart> this patch introduces a 64-bit division? If so, I'm afraid this
Bart> patch will make 32-bit users unhappy. Have you considered to use
Bart> do_div() or >> (ilog2(block_size) - 9) instead? For the latter
Bart> alternative no 64-bit cast is needed.

Please use logical_to_sectors().

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]