On Mon, Jul 01, 2013 at 10:03:11PM +0200, Rafael J. Wysocki wrote: > On 7/1/2013 8:34 PM, Greg KH wrote: > >On Sat, Jun 29, 2013 at 04:31:39AM +0100, Ben Hutchings wrote: > >>On Thu, 2013-06-27 at 13:44 -0700, Yinghai Lu wrote: > >>>On Thu, Jun 27, 2013 at 1:00 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > >>>>On Thu, Jun 27, 2013 at 12:30:25PM -0700, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > >>>>>This is a note to let you know that I've just added the patch titled > >>>>> > >>>>> PCI: acpiphp: Re-enumerate devices when host bridge receives Bus Check > >>>>> > >>>>>to the 3.9-stable tree which can be found at: > >>>>> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > >>>>> > >>>>>The filename of the patch is: > >>>>> pci-acpiphp-re-enumerate-devices-when-host-bridge-receives-bus-check.patch > >>>>>and it can be found in the queue-3.9 subdirectory. > >>>>> > >>>>>If you, or anyone else, feels it should not be added to the stable tree, > >>>>>please let <stable@xxxxxxxxxxxxxxx> know about it. > >>>>> > >>>>> > >>>>>>From 3f327e39b4b8f760c331bb2836735be6d83fbf53 Mon Sep 17 00:00:00 2001 > >>>>And this one fails to link because of the previous ones not being > >>>>present, so it's now dropped as well... > >>>What are previous ones? > >>> > >>>668192b678 ("PCI: acpiphp: Move host bridge hotplug to > >>>pci_root.c") is not in your tree? > >>The problem is you didn't export acpiphp_check_host_bridge. And I think > >>you would have to remove the module_exit function from acpiphp rather > >>than just clearing that pointer and hoping no-one called through it > >>recently. > >> > >>Alternately, Greg could just cherry-pick commit > >>6037a803b05eef9943fb64982e19964007fb7478 'PCI: acpiphp: Convert acpiphp > >>to be builtin only, not modular'. acpiphp was never very useful as a > >>module since it didn't get auto-loaded. > >We couldn't auto-load it as that would have broken some systems a number > >of years ago, that's why I did it that way. > > > >Even with cherry-picking 6037a803b05eef9943fb64982e19964007fb7478, > >commit 3f327e39b4b8f760c331bb2836735be6d83fbf53 doesn't apply properly, > >so I'll just wait for a developer to care enough to send me patches that > >actually apply and build properly for 3.9-stable if they want them there > >:) > > Honestly, I'm not sure about backporting 'PCI: acpiphp: Convert > acpiphp to be builtin only, not modular' and things depending on it > to -stable, as it is a major redesign of the subsystem and we can > easily break stuff while doing the backport, in which case we'll > have bugs in -stable that aren't present in the mainline. I agree, this probably shouldn't be in the 3.9 kernel, especially as 3.10 is out so anyone having these problems can just move to that release. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html