gregkh@xxxxxxxxxxxxxxxxxxx writes: > This is a note to let you know that I've just added the patch titled > > paride: make 'verbose' parameter an 'int' again > > to the 3.14-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > paride-make-verbose-parameter-an-int-again.patch > and it can be found in the queue-3.14 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@xxxxxxxxxxxxxxx> know about it. > > >>From dec63a4dec2d6d01346fd5d96062e67c0636852b Mon Sep 17 00:00:00 2001 > From: Arnd Bergmann <arnd@xxxxxxxx> > Date: Tue, 15 Mar 2016 14:53:29 -0700 > Subject: paride: make 'verbose' parameter an 'int' again > > From: Arnd Bergmann <arnd@xxxxxxxx> > > commit dec63a4dec2d6d01346fd5d96062e67c0636852b upstream. > > gcc-6.0 found an ancient bug in the paride driver, which had a > "module_param(verbose, bool, 0);" since before 2.6.12, but actually uses > it to accept '0', '1' or '2' as arguments: > > drivers/block/paride/pd.c: In function 'pd_init_dev_parms': > drivers/block/paride/pd.c:298:29: warning: comparison of constant '1' with boolean expression is always false [-Wbool-compare] > #define DBMSG(msg) ((verbose>1)?(msg):NULL) > > In 2012, Rusty did a cleanup patch that also changed the type of the > variable to 'bool', which introduced what is now a gcc warning. > > This changes the type back to 'int' and adapts the module_param() line > instead, so it should work as documented in case anyone ever cares about > running the ancient driver with debugging. > > Fixes: 90ab5ee94171 ("module_param: make bool parameters really bool (drivers & misc)") Hmm, I got CC'd on this, not the original :( Because it *never* worked. 90ab5ee94171 changed it to a bool, but it was already module_param(bool) so you could never set it to 2. ... And it's been module_param(bool) before 2005. But this breaks anyone who has been using just "verbose" or "verbose=y". Fortunately, I'm sure nobody cares about it? Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html