Re: dm cache metadata: fix cmd_read_lock acquiring write lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 17 2016 at  1:37P -0400,
Ahmed Samy <f.fallen45@xxxxxxxxx> wrote:

> commit 9567366fefdd ("dm cache metadata: fix READ_LOCK macros and cleanup WRITE_LOCK macros")
> seemed to use down_write instead of down_read in cmd_read_lock(), yet
> releasing it with up_read() in READ_UNLOCK.  Fix it.
> 
> Cc: Mike Snitzer <snitzer@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Ahmed Samy <f.fallen45@xxxxxxxxx>

Ugh, very frustrating -- I must've looked at this code 3 different times
to try to make sure I didn't have a thinko.  And strangely sparse didn't
catch this locking bug (from cut-n-paste).

Anyway, thanks... I'll see if I can get this to Linus ASAP.

Mike
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]