Re: Build errors in 3.4 stable patch queue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: David Miller <davem@xxxxxxxxxxxxx>
Date: Tue, 25 Jun 2013 12:25:26 -0700 (PDT)

> Can you at least look at the guilty bonding patch in question?  It
> adds ether_addr_equal() to linux/etherdevice.h, specifically to deal
> with this issue.

I see what the issue is, nevermind.  In earlier trees the routines are
named "compare_ether_addr()" and have opposite return logic to the
current ones.

I would say that in 3.4, 3.2, and 3.0 we fix this by changing the
bonding alb fix, in bond_slave_has_mac(), to use:

		if (!compare_ether_addr_64bits(mac, tmp->dev->dev_addr))
			return tmp;

instead of:

		if (ether_addr_equal_64bits(mac, tmp->dev->dev_addr))
			return tmp;

And then remove the linux/etherdevice.h part of the patch entirely.

Greg can you take care of this?  Thanks!
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]