Patch "ALSA: hda - Don't handle ELD notify from invalid port" has been added to the 4.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    ALSA: hda - Don't handle ELD notify from invalid port

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     alsa-hda-don-t-handle-eld-notify-from-invalid-port.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.


>From 4f8e4f3537cafc4de128e6bfdf83baa78bc60eb1 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@xxxxxxx>
Date: Thu, 10 Mar 2016 12:02:49 +0100
Subject: ALSA: hda - Don't handle ELD notify from invalid port

From: Takashi Iwai <tiwai@xxxxxxx>

commit 4f8e4f3537cafc4de128e6bfdf83baa78bc60eb1 upstream.

The current Intel HDMI codec driver supports only three fixed ports
from port B to port D.  However, i915 driver may assign a DP on other
ports, e.g. port A, when no eDP is used.  This incompatibility is
caught later at pin_nid_to_pin_index() and results in a warning
message like "HDMI: pin nid 4 not registered" at each time.

This patch filters out such invalid events beforehand, so that the
kernel won't be too grumbling.

Reported-by: Stefan Assmann <sassmann@xxxxxxxxx>
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
 sound/pci/hda/patch_hdmi.c |    4 ++++
 1 file changed, 4 insertions(+)

--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -2353,6 +2353,10 @@ static void intel_pin_eld_notify(void *a
 	struct hda_codec *codec = audio_ptr;
 	int pin_nid = port + 0x04;
 
+	/* we assume only from port-B to port-D */
+	if (port < 1 || port > 3)
+		return;
+
 	/* skip notification during system suspend (but not in runtime PM);
 	 * the state will be updated at resume
 	 */


Patches currently in stable-queue which might be from tiwai@xxxxxxx are

queue-4.4/alsa-hda-apply-reboot-d3-fix-for-cx20724-codec-too.patch
queue-4.4/alsa-intel8x0-add-clock-quirk-entry-for-ad1981b-on-ibm-thinkpad-x41.patch
queue-4.4/alsa-usb-audio-add-microsoft-hd-5001-to-quirks.patch
queue-4.4/alsa-usb-audio-fix-null-dereference-in-create_fixed_stream_quirk.patch
queue-4.4/alsa-usb-audio-minor-code-cleanup-in-create_fixed_stream_quirk.patch
queue-4.4/alsa-pcm-avoid-bug-string-for-warnings-again.patch
queue-4.4/alsa-usb-audio-fix-double-free-in-error-paths-after-snd_usb_add_audio_stream-call.patch
queue-4.4/alsa-hda-fix-unconditional-gpio-toggle-via-automute.patch
queue-4.4/alsa-hda-don-t-handle-eld-notify-from-invalid-port.patch
queue-4.4/alsa-usb-audio-add-sanity-checks-for-endpoint-accesses.patch
queue-4.4/alsa-hda-fix-the-mic-mute-button-and-led-problem-for-a-lenovo-aio.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]