Re: [PATCH v2] Revert "PCI: imx6: Add support for active-low reset GPIO"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bjorn,

On Wed, Mar 30, 2016 at 10:29 AM, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote:
> Am Montag, den 28.03.2016, 18:45 -0300 schrieb Fabio Estevam:
>> From: Fabio Estevam <fabio.estevam@xxxxxxx>
>>
>> Commit 5c5fb40de8f14 ("PCI: imx6: Add support for active-low reset GPIO")
>> cause regressions on some boards like MX6 Gateworks Ventana, for example.
>>
>> The reason for the breakage is that this commit sets the gpio polarity
>> in the wrong logic level.
>>
>> Also, the commit log is wrong because active-low reset GPIO is what the
>> driver used to support since the beginning.
>>
>> So keep the old behavior that ignores the gpio polarity specified in
>> the device tree and treat the PCI reset GPIO as active-low.
>>
>> Cc: <stable@xxxxxxxxxxxxxxx> # 4.5
>> Reported-by: Krzysztof Hałasa <khalasa@xxxxxxx>
>> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
>
> We need to keep compatibility to existing DTs that are setting the GPIO
> active polarity in the wrong way, so this revert is correct:
>
> Acked-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>

Any chance to get this into 4.6-rc3 to fix the regression?
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]