Re: [PATCH v1 1/1] ata: sata_dwc_460ex: make driver works again

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 18, 2016 at 04:48:55PM +0200, Andy Shevchenko wrote:
> This patch basically reverts three commits
> 	8d5fe8d sata_dwc_460ex: indent an if statement
> 	db7a657f sata_dwc_460ex: re-use hsdev->dev instead of dwc_dev
> 	8b34448 sata_dwc_460ex: move to generic DMA driver
> to make driver works on _stable_ kernels only.
> 
> The mentioned set has few flaws which are addressed in the continuation of this
> series. At that time no-one has a possibility to check that on an actual
> hardware. But now I have access to it and thus can be sure that everything
> works beforehand.
> 
> The decision to revert is based on the fact of amount of efforts needed to back
> port necessary changes.
> 
> Fixes: 8b3444852a2b ("sata_dwc_460ex: move to generic DMA driver")
> Cc: stable@xxxxxxxxxxxxxxx # v4.1+
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> 
> Tejun, this is intended explicitly for stable kernels only (v4.1..v4.6-rcX).
> Mans and I are going to fix it in the upstrem this cycle. I have alredy send a
> patch series regarding DMA fixes.
> 
>  drivers/ata/sata_dwc_460ex.c | 753 +++++++++++++++++++++++++++++++++++--------
>  1 file changed, 623 insertions(+), 130 deletions(-)

That's not ok for a stable patch, sorry, please go read
Documentation/stable_kernel_rules.txt.

Just revert the individual patches instead, what's wrong with that?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]