Re: [PATCH] MIPS: fix build error when SMP is used without GIC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 03/06/2016 05:15 PM, Hauke Mehrtens wrote:

The MIPS_GIC_IPI should only be selected when MIPS_GIC is also
selected, otherwise it results in a compile error. smp-gic.c uses some
functions form include/linux/irqchip/mips-gic.h like

  s/form/from/.

plat_ipi_call_int_xlate() which are only added to the header file when
MIPS_GIC is set. The Lantiq SoC does not use the GIC, but supports SMP.
The calls top the functions from smp-gic.c are laready protected by

   s/laready/already/.

some #ifdefs

The first part of this was introduced in commit 72e20142b "MIPS: Move
GIC IPI functions out of smp-cmp.c"

scripts/checkpatch.pl now enforces certain commit citing style, yours doesn't quite match it...

Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
Cc: Paul Burton <paul.burton@xxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx> # v3.15+

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]