Re: FAILED: patch "[PATCH] iwlwifi: mvm: don't allow sched scans without matches to be" failed to apply to 4.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

This is strange... I just tried to cherry-pick it on top of 4.4.3 and
it applied cleanly.

Do you want me to send it again anyway?

--
Cheers,
Luca.

On Tue, 2016-03-01 at 10:45 -0800, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> The patch below does not apply to the 4.4-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git
> commit
> id to <stable@xxxxxxxxxxxxxxx>.
> 
> thanks,
> 
> greg k-h
> 
> ------------------ original commit in Linus's tree ------------------
> 
> From 5e56276e7555b34550d51459a801ff75eca8b907 Mon Sep 17 00:00:00
> 2001
> From: Luca Coelho <luciano.coelho@xxxxxxxxx>
> Date: Tue, 2 Feb 2016 15:11:15 +0200
> Subject: [PATCH] iwlwifi: mvm: don't allow sched scans without
> matches to be
>  started
> 
> The firmware can perform a scheduled scan with not matchsets passed,
> but it can't send notification that results were found.  Since the
> userspace then cannot know when we got new results and the firmware
> wouldn't trigger a wake in case we are sleeping, it's better not to
> allow scans without matchsets.
> 
> This fixes https://bugzilla.kernel.org/show_bug.cgi?id=110831
> 
> Cc: <stable@xxxxxxxxxxxxxxx> [3.17+]
> Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> index 9a15642f80dd..ea1e177c2ea1 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/scan.c
> @@ -1298,6 +1298,10 @@ int iwl_mvm_sched_scan_start(struct iwl_mvm
> *mvm,
>  		return -EBUSY;
>  	}
>  
> +	/* we don't support "match all" in the firmware */
> +	if (!req->n_match_sets)
> +		return -EOPNOTSUPP;
> +
>  	ret = iwl_mvm_check_running_scans(mvm, type);
>  	if (ret)
>  		return ret;
> ��.n��������+%������w��{.n�����������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]