This is a note to let you know that I've just added the patch titled
[media] si2157: return -EINVAL if firmware blob is too big
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
si2157-return-einval-if-firmware-blob-is-too-big.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From d2cc2f0b35465951eaaf0387fd55e29835ed7ea6 Mon Sep 17 00:00:00 2001
From: Laura Abbott <labbott@xxxxxxxxxxxxxxxxx>
Date: Mon, 5 Oct 2015 19:33:29 -0300
Subject: [media] si2157: return -EINVAL if firmware blob is too big
From: Laura Abbott <labbott@xxxxxxxxxxxxxxxxx>
commit d2cc2f0b35465951eaaf0387fd55e29835ed7ea6 upstream.
A previous patch added a check if the firmware is too big, but it didn't
set the return error code with the right value.
[mchehab@xxxxxxxxxxxxxxx: I ended by applying a v1 of Laura's patch, without
the proper return code. This patch contains the difference between v2 and v1 of
the Laura's "si2157: Bounds check firmware" patch]
Signed-off-by: Laura Abbott <labbott@xxxxxxxxxxxxxxxxx>
Reviewed-by: Olli Salonen <olli.salonen@xxxxxx>
Tested-by: Olli Salonen <olli.salonen@xxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxx>
---
drivers/media/tuners/si2157.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/media/tuners/si2157.c
+++ b/drivers/media/tuners/si2157.c
@@ -168,6 +168,7 @@ static int si2157_init(struct dvb_fronte
len = fw->data[fw->size - remaining];
if (len > SI2157_ARGLEN) {
dev_err(&client->dev, "Bad firmware length\n");
+ ret = -EINVAL;
goto err_release_firmware;
}
memcpy(cmd.args, &fw->data[(fw->size - remaining) + 1], len);
Patches currently in stable-queue which might be from labbott@xxxxxxxxxxxxxxxxx are
queue-4.4/si2157-return-einval-if-firmware-blob-is-too-big.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html