On 26/02/2016 13:14, Nadav Amit wrote: > Seems correct. The code may be easier to follow if the following line: > > vcpu->arch.switch_db_regs &= ~KVM_DEBUGREG_WONT_EXIT > > would have been moved out of svm_sync_dirty_debug_regs and > vmx_sync_dirty_debug_regs into the flow of vcpu_enter_guest (above). It is there because removing the bit is tied to actually enabling debug register exits. On one hand it's bad to have duplicated code, on the other hand there's a reason for it... I'm a bit undecided on whether to move that duplicated line to x86.c. Paolo -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html