Re: [PATCH] x86/efi: Fix dummy variable buffer allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 16 Jun, at 09:27:12PM, Ben Hutchings wrote:
> 1. Check for allocation failure
> 2. Clear the buffer contents, as they may actually be written to flash
> 3. Don't leak the buffer
> 
> Compile-tested only.
> 
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> ---
>  arch/x86/platform/efi/efi.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

Oops. This looks good to me, Ben. The writing of random kernel memory to
flash is particularly bad.

Matthew, care to Ack? I'll add this to my urgent queue.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]