This is a note to let you know that I've just added the patch titled Revert "ALSA: hda - Fix noise on Gigabyte Z170X mobo" to the 4.3-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: revert-alsa-hda-fix-noise-on-gigabyte-z170x-mobo.patch and it can be found in the queue-4.3 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 6c361d10e0eb859233c71954abcd20d2d8700587 Mon Sep 17 00:00:00 2001 From: Takashi Iwai <tiwai@xxxxxxx> Date: Fri, 5 Feb 2016 20:12:24 +0100 Subject: Revert "ALSA: hda - Fix noise on Gigabyte Z170X mobo" From: Takashi Iwai <tiwai@xxxxxxx> commit 6c361d10e0eb859233c71954abcd20d2d8700587 upstream. This reverts commit 0c25ad80408e95e0a4fbaf0056950206e95f726f. The original commit disabled the aamixer path due to the noise problem, but it turned out that some mobo with the same PCI SSID doesn't suffer from the issue, and the disabled function (analog loopback) is still demanded by users. Since the recent commit [e7fdd52779a6: ALSA: hda - Implement loopback control switch for Realtek and other codecs], we have the dynamic mixer switch to enable/disable the aamix path, and we don't have to disable the path statically any longer. So, let's revert the disablement, so that only the user suffering from the noise problem can turn off the aamix on the fly. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=108301 Reported-by: <mutedbytes@xxxxxxxxx> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- sound/pci/hda/patch_realtek.c | 8 -------- 1 file changed, 8 deletions(-) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -1795,7 +1795,6 @@ enum { ALC882_FIXUP_NO_PRIMARY_HP, ALC887_FIXUP_ASUS_BASS, ALC887_FIXUP_BASS_CHMAP, - ALC882_FIXUP_DISABLE_AAMIX, }; static void alc889_fixup_coef(struct hda_codec *codec, @@ -1957,8 +1956,6 @@ static void alc882_fixup_no_primary_hp(s static void alc_fixup_bass_chmap(struct hda_codec *codec, const struct hda_fixup *fix, int action); -static void alc_fixup_disable_aamix(struct hda_codec *codec, - const struct hda_fixup *fix, int action); static const struct hda_fixup alc882_fixups[] = { [ALC882_FIXUP_ABIT_AW9D_MAX] = { @@ -2196,10 +2193,6 @@ static const struct hda_fixup alc882_fix .type = HDA_FIXUP_FUNC, .v.func = alc_fixup_bass_chmap, }, - [ALC882_FIXUP_DISABLE_AAMIX] = { - .type = HDA_FIXUP_FUNC, - .v.func = alc_fixup_disable_aamix, - }, }; static const struct snd_pci_quirk alc882_fixup_tbl[] = { @@ -2267,7 +2260,6 @@ static const struct snd_pci_quirk alc882 SND_PCI_QUIRK(0x1462, 0x7350, "MSI-7350", ALC889_FIXUP_CD), SND_PCI_QUIRK_VENDOR(0x1462, "MSI", ALC882_FIXUP_GPIO3), SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte EP45-DS3/Z87X-UD3H", ALC889_FIXUP_FRONT_HP_NO_PRESENCE), - SND_PCI_QUIRK(0x1458, 0xa182, "Gigabyte Z170X-UD3", ALC882_FIXUP_DISABLE_AAMIX), SND_PCI_QUIRK(0x147b, 0x107a, "Abit AW9D-MAX", ALC882_FIXUP_ABIT_AW9D_MAX), SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", ALC882_FIXUP_EAPD), SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_FIXUP_EAPD), Patches currently in stable-queue which might be from tiwai@xxxxxxx are queue-4.3/alsa-seq-fix-race-at-closing-in-virmidi-driver.patch queue-4.3/alsa-hda-fix-bad-dereference-of-jack-object.patch queue-4.3/c8sectpfe-remove-select-on-config_fw_loader_user_helper_fallback.patch queue-4.3/alsa-usb-audio-add-quirk-for-microsoft-lifecam-hd-6000.patch queue-4.3/alsa-rawmidi-remove-kernel-warning-for-null-user-space-buffer-check.patch queue-4.3/alsa-usb-audio-fix-oppo-ha-1-vendor-id.patch queue-4.3/alsa-timer-fix-race-at-concurrent-reads.patch queue-4.3/alsa-hda-fix-static-checker-warning-in-patch_hdmi.c.patch queue-4.3/alsa-seq-fix-lockdep-warnings-due-to-double-mutex-locks.patch queue-4.3/alsa-usb-audio-fix-teac-ud-501-ud-503-nt-503-usb-delay.patch queue-4.3/alsa-timer-fix-wrong-instance-passed-to-slave-callbacks.patch queue-4.3/alsa-hda-implement-loopback-control-switch-for-realtek-and-other-codecs.patch queue-4.3/alsa-seq-degrade-the-error-message-for-too-many-opens.patch queue-4.3/alsa-compress-disable-get_codec_caps-ioctl-for-some-architectures.patch queue-4.3/alsa-rawmidi-make-snd_rawmidi_transmit-race-free.patch queue-4.3/alsa-hda-fix-speaker-output-from-vaio-aio-machines.patch queue-4.3/alsa-bebob-use-a-signed-return-type-for-get_formation_index.patch queue-4.3/alsa-dummy-implement-timer-backend-switching-more-safely.patch queue-4.3/alsa-dummy-disable-switching-timer-backend-via-sysfs.patch queue-4.3/alsa-seq-fix-incorrect-sanity-check-at-snd_seq_oss_synth_cleanup.patch queue-4.3/alsa-seq-fix-yet-another-races-among-alsa-timer-accesses.patch queue-4.3/alsa-usb-audio-avoid-freeing-umidi-object-twice.patch queue-4.3/revert-alsa-hda-fix-noise-on-gigabyte-z170x-mobo.patch queue-4.3/alsa-hda-add-fixup-for-mac-mini-7-1-model.patch queue-4.3/alsa-usb-audio-add-native-dsd-support-for-ps-audio-nuwave-dac.patch queue-4.3/alsa-timer-fix-leftover-link-at-closing.patch queue-4.3/alsa-rawmidi-fix-race-at-copying-updating-the-position.patch queue-4.3/alsa-pcm-fix-potential-deadlock-in-oss-emulation.patch queue-4.3/alsa-timer-fix-link-corruption-due-to-double-start-or-stop.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html