Re: [PATCH v1 1/1] dmaengine: dw: disable BLOCK IRQs for non-cyclic xfer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10-02-16, 15:59, Andy Shevchenko wrote:
> The commit 2895b2cad6e7 ("dmaengine: dw: fix cyclic transfer callbacks")
> re-enabled BLOCK interrupts with regard to make cyclic transfers work. However,
> this change becomes a regression for non-cyclic transfers as interrupt counters
> under stress test had been grown enormously (approximately per 4-5 bytes in the
> UART loop back test).
> 
> Taking into consideration above enable BLOCK interrupts if and only if channel
> is programmed to perform cyclic transfer.
> 
> Fixes: 2895b2cad6e7 ("dmaengine: dw: fix cyclic transfer callbacks")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Mans Rullgard <mans@xxxxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>
> ---
>  drivers/dma/dw/core.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]